Lower handoff artifact warnings to debug#3531
Conversation
Generated-By: PostHog Code Task-Id: a72538a4-57ff-4bb0-ac51-133ba48fba99
|
😎 Merged directly without going through the merge queue, as the queue was empty and the PR was up to date with the target branch - details. |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
tatoalo
added
the
Stamphog
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Reviews (1): Last reviewed commit: "Lower handoff artifact logs to debug" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| this.logger.debug( | ||
| "Discarding handoff checkpoint: required artifact uploads did not complete", |
There was a problem hiding this comment.
This branch also runs when required uploads are missing because direct and inline upload attempts failed, not only when an artifact exceeded its expected size limit. Log collectors that exclude debug entries will lose the final checkpoint-discard event and its checkpoint ID, upload state, and artifact sizes, making unexpected checkpoint loss harder to diagnose.
| this.logger.debug( | |
| "Discarding handoff checkpoint: required artifact uploads did not complete", | |
| this.logger.warn( | |
| "Discarding handoff checkpoint: required artifact uploads did not complete", |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
1 participant
Problem
Routine handoff artifact size limits are expected behavior but currently appear as warnings to users, adding noise to the visible log stream.
Changes
Lower the artifact-size skip and resulting checkpoint-discard messages from warning to debug level.